Replace custom http events with aws_lambda_events#426
Merged
Conversation
calavera
commented
Feb 19, 2022
| "CloudFront-Viewer-Country":[ | ||
| "US" | ||
| ], | ||
| "":[ |
Contributor
Author
There was a problem hiding this comment.
I removed this because empty header names are not supposed to be valid. http::HeaderMap will panic if it finds any empty name.
The Alb and ApiGw events in aws_lambda_events are thoroughly tested with multiple payloads that those services generate. Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
ApiGw use $default as an identifier, but it doesn't add it to the URI. Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
force-pushed
the
update_http_events
branch
from
6895643 to
1e853d2
Compare
Signed-off-by: David Calavera <david.calavera@gmail.com>
nmoutschen
approved these changes
Feb 19, 2022
nmoutschen
left a comment
nmoutschen
left a comment
Contributor
There was a problem hiding this comment.
LGTM! This also passes all the integration tests. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Alb and ApiGw events in aws_lambda_events are thoroughly tested
with multiple payloads that those services generate.
Signed-off-by: David Calavera david.calavera@gmail.com
Issue #, if available:
resourcefield #307Description of changes:
By submitting this pull request